Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new fields to Metadata class #2961

Merged
merged 31 commits into from
Feb 18, 2024
Merged

Add new fields to Metadata class #2961

merged 31 commits into from
Feb 18, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Feb 15, 2024 •
edited
Loading

  • Added src_node_id, dst_node_id, reply_to_message fields to Metadata class
  • Made metadata field in Message and some fields in Metadata read-only
  • Added message validity check in the client main loop

@panh99 panh99 marked this pull request as ready for review February 16, 2024 08:12
danieljanes
danieljanes reviewed Feb 17, 2024
View reviewed changes
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/grpc_rere_client/connection.py Show resolved Hide resolved
@danieljanes danieljanes merged commit da682a1 into main Feb 18, 2024
27 checks passed
@danieljanes danieljanes deleted the expand-metadata branch February 18, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq